feat: Yul-based wrapper for ECDSA (#244) #433
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new Yul-based wrapper for ECDSA signature recovery under
utils/ECDSA.sol.This implementation focuses on gas efficiency, malformed signature tolerance, and low-level assembly optimization compared to OpenZeppelin’s version.
The file exposes a single function:
recover(bytes32 hash, bytes memory sig):address(0)on invalid or malleable input.Also included comprehensive tests in
test/utils/ECDSAT.t.solto validate:s > n/2)Checklist
forge snapshotnpm run lintforge test— All tests passing with custom Yul and OpenZeppelin comparisons.