Fix defunct dfm and tokens usages #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `dfm.character()` is deprecated in v3 and defunct in v4 * `stem` is no longer an argument for `tokens()` or `dfm()` Note also that `dfm()` in **quanteda** v4 is also faster by up to 30% as we re-implemented it in C++.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes will ensure that your package does not break when we publish quanteda v4.
Breaking changes:
dfm.character()is deprecated in v3 and defunct in v4stemis no longer an argument fortokens()ordfm()Note also that
dfm()in quanteda v4 is also faster by up to 30% as we re-implemented it in C++.