Clustering code for CV results #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskewParity
approved these changes
Nov 9, 2025
Contributor
AskewParity
left a comment
AskewParity
left a comment
There was a problem hiding this comment.
Thanks for doing this. Everything in src looks good.
My only comments are for the integration test, but I don't think you should need to change them right now.
- We already have a random function
- There is little to no documentation about how it works (what colors mean what on the plot, where to find the plot(s))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #314
A naive implementation of a cluster algorithm using Lat/Long medians, as well as an integration test to visualize the results. The algorithm could probably be improved a lot once we are more aware of what the data will look like.