-
Notifications
You must be signed in to change notification settings - Fork 0
Dev/camera/tcp socket/tyler #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
miyatakazuya
wants to merge
30
commits into
main
Choose a base branch
from
dev/camera/tcp-socket/tyler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added synchronous client and synchronous test server able to serialize data in a struct and send it between client and server can also successfully send an image, however not in the yuv420 as expected from the RPI side sync_client_mock.cpp and sync_server_mock.cpp need to be run separately and the server needs to be started first in order for the client to successfully connect to it currently working on converting everything into asynchronous Asynchronous TODOS - need to make the async client thread safe, need to learn how to use strand and such to protect shared resources and the execution context - need to ensure that requests to take images complete in the requested order, in other words no images out of order. this isn't a problem in the synchronous version but asynchronous needs to handle it - what do we do in the case any of the async functions fail? - once we receive the image in yuv420 format, does it need to be reassembled by imgConvert() or is that on the cv pipeline? also need to save to local storage instead of keeping it in memory what is the expected format to save as? i.e name or title - also need to handle errors
…red functionality. Need to further change to support the RPI functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.