Cleanup outdated todos #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove two outdated items from content_editing.py: - Outdated TODO comment for Phase 1 transition (already implemented) - Stub _page_indexing_worker method (page indexing runs in Phase 1 only) The page indexing functionality is fully implemented in block_selection.py:770 (Phase 1) where it runs with proper dependency coordination. Phase 2's _rag_search_worker correctly waits for the Phase 1 indexing task to complete. Assisted-by: Claude Code
…isions Show a toast notification when user tries to advance to the next block but integration decisions are still being generated by the LLM worker. This provides clear feedback instead of silently ignoring the navigation key press, improving user experience during the opportunistic worker execution pattern where decisions may still be streaming. Resolves the TODO at integration_review.py:829. Assisted-by: Claude Code
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 84.61% 84.62% +0.01%
==========================================
Files 48 48
Lines 5088 5087 -1
==========================================
Hits 4305 4305
+ Misses 783 782 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.