feat:added profile functionality #272
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Avantol13
requested changes
Sep 9, 2025
gen3/cli/__main__.py
Outdated
|
|
||
| if profile_name and not auth_config: | ||
| try: | ||
| import gen3.configure as config_tool |
Contributor
There was a problem hiding this comment.
let's make sure all imports are at the top level
gen3/cli/__main__.py
Outdated
|
|
||
| if self.profile_name and not self.refresh_file: | ||
| try: | ||
| import gen3.configure as config_tool |
Contributor
There was a problem hiding this comment.
let's make sure all imports are at the top level
gen3/cli/configure.py
Outdated
|
|
||
|
|
||
| @click.command() | ||
| def list_profiles(): |
Contributor
There was a problem hiding this comment.
try not to have multiples of the same named function, it can get confusing. Just call this list_all_profiles instead
gen3/configure.py
Outdated
|
|
||
| logging = get_logger("__name__") | ||
|
|
||
| CONFIG_FILE_PATH = expanduser("~/.gen3/config") |
Contributor
There was a problem hiding this comment.
was this used anywhere? If not, we should just replace it entirely with the new config
Contributor
There was a problem hiding this comment.
it looks like the old config was never really finished, so let's remove all this old code and replace with the new config
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Signed-off-by: Dhiren-Mhatre <kp064669@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features