-
Notifications
You must be signed in to change notification settings - Fork 16
build: replace hash with build increment in slackware txz pkg #1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update introduces a required build number parameter throughout the plugin build process, starting from workflow inputs, propagating through build scripts, and integrating into file naming, URL generation, and environment schemas. The changes ensure the build number is consistently included in artifacts and workflow steps, improving traceability and reproducibility. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant build-api job
participant build-plugin-staging-pr job
participant build-plugin-production job
participant Build Scripts
GitHub Actions->>build-api job: Start build-api
build-api job->>build-api job: Generate build_number
build-api job-->>GitHub Actions: Output build_number
GitHub Actions->>build-plugin-staging-pr job: Pass BUILD_NUMBER from build-api
GitHub Actions->>build-plugin-production job: Pass BUILD_NUMBER from build-api
build-plugin-staging-pr job->>Build Scripts: Run build with --build-number
build-plugin-production job->>Build Scripts: Run build with --build-number
Build Scripts->>Build Scripts: Incorporate build_number in naming and URLs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (6)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
eb74c72 to
debafbe
Compare
|
This plugin has been deployed to Cloudflare R2 and is available for testing. |
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Introduced support for specifying and propagating a build number throughout the build process, including command-line options and workflow inputs. * TXZ package naming and URLs now include the build number for improved traceability. * **Improvements** * Enhanced robustness in locating TXZ files with improved fallback logic, especially in CI environments. * Improved flexibility and validation of environment schema for plugin builds. * **Style** * Minor formatting corrections for consistency and readability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1210677942019563
Summary by CodeRabbit
New Features
Improvements
Style