Fix editing autofilled values in Chrome #1093
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to stop Chrome from thinking the user never inputed any thing when autofilling. Otherwise Chrome will keep autofilling.
Deploying smoothly with
|
| Latest commit: |
f20b335
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://42233a8f.smoothly.pages.dev |
| Branch Preview URL: | https://remove-prevent-default-from.smoothly.pages.dev |
Contributor
Author
|
This PR seems to break the autofill on load for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all
preventDefaultfrombeforeinputevents.The
preventDefaultmade it seem to Chrome that the user never typed and so it would autofill the value again when it changed.cant-remove-password-in-chrome.mp4
Unfortunately the autofill is still not perfect since if you keep switching what values are autofill it will sometimes not autofill the correct values you choose (this bug is not new). Makes me think that maybe logins should just use regular input and form elements, and just listen to the submit for formdata instead. But this PR is at least an improvement.