ln: Using unit test macros for ln and creating test cases for exception handling #9625
+92
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDryden
commented
Dec 10, 2025
| }; | ||
|
|
||
| exec(&paths[..], &settings) | ||
| exec(&paths, &settings) |
Collaborator
Author
There was a problem hiding this comment.
Was a bit confused when trying to understand what the [..] was doing when I was reading this, turns out its redundant
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
ChrisDryden
force-pushed
the
ln_testing_and_cleanup
branch
2 times, most recently
from
43e26c0 to
b3eb56c
Compare
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #9625 will not alter performanceComparing Summary
Footnotes
|
cakebaker
reviewed
Dec 11, 2025
|
GNU testsuite comparison: |
ChrisDryden
force-pushed
the
ln_testing_and_cleanup
branch
from
3df36e3 to
d10697b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through the coverlay of ln to see where we are missing coverage and found a few edge cases that I was looking to cover with tests. It was interesting to see that one of the error messages was actually impossible to reach on unix, so I ended up adding a cfg to only run it for windows.
I also updated the using of the macros in the tests since half of the tests were using them and half of them weren't