Skip to content

Conversation

@ChrisDryden
Copy link
Collaborator

@ChrisDryden ChrisDryden commented Dec 12, 2025

Not for review just for discussion and validation of pipeline handler approach

I took the change that mattsu2020 made to be able to track the pipe signals and just did some messing around to see if that approach could work for all of the pipe related tests. Will use this for inspiration to make PR's for each one individually. I found that some of the original changes didn't work and that the other GNU tests have different expectations for how seq fails

@ChrisDryden ChrisDryden force-pushed the fix-gnu-close-stdout-tests branch 3 times, most recently from b2e75a8 to 696bffb Compare December 12, 2025 21:15
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/fold/fold-characters. tests/fold/fold-characters is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/pipe-f2. tests/tail/pipe-f2 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/env/env-signal-handler is no longer failing!
Congrats! The gnu test tests/seq/seq-epipe is no longer failing!
Congrats! The gnu test tests/tail/follow-stdin is no longer failing!
Congrats! The gnu test tests/tail/pid-pipe is no longer failing!
Congrats! The gnu test tests/tail/pipe-f is no longer failing!
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@ChrisDryden ChrisDryden force-pushed the fix-gnu-close-stdout-tests branch 2 times, most recently from b1f259d to c8e1c48 Compare December 12, 2025 22:03
@ChrisDryden ChrisDryden force-pushed the fix-gnu-close-stdout-tests branch from c8e1c48 to 060fba1 Compare December 12, 2025 22:11
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 12, 2025

CodSpeed Performance Report

Merging #9646 will degrade performances by 2.54%

Comparing ChrisDryden:fix-gnu-close-stdout-tests (060fba1) with main (8ec02e7)

Summary

❌ 2 regressions
✅ 125 untouched
⏩ 6 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
du_summarize_balanced_tree[(5, 4, 10)] 8.3 ms 8.5 ms -2.2%
cp_large_file[16] 354.1 µs 363.3 µs -2.54%

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail/pipe-f2. tests/tail/pipe-f2 is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/env/env-signal-handler is no longer failing!
Congrats! The gnu test tests/seq/seq-epipe is no longer failing!
Congrats! The gnu test tests/tail/follow-stdin is no longer failing!
Congrats! The gnu test tests/tail/pid-pipe is no longer failing!
Congrats! The gnu test tests/tail/pipe-f is no longer failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants