-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Drop hashsum in favor of standalone binaries #9776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Do you want to avoid |
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #9776 will degrade performance by 16.5%Comparing Summary
Benchmarks breakdown
Footnotes
|
No, in my mind, we have separate binaries for cksum, b2sum, md5sum, etc... |
| basename \ | ||
| cat \ | ||
| cksum \ | ||
| b2sum \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why b2sum only? Just forgot other bins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No no, it's the reason it's still in draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hasusum.rs is still remain. But we remove it later and totail size of source code is reduced. Right?
|
We have Lines 96 to 101 in 0fbc17c
(I have a PR to use coreutils for faster CI at GnuTests to remove it, but not merged.)
|
588c1e7 to
0d46fcb
Compare
|
GNU testsuite comparison: |
0d46fcb to
9f2c7fb
Compare
|
GNU testsuite comparison: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this .png needed (instead of symlink to logo)?
|
#9797 OK before this? |
|
I think 6 PR (each bins) for this is OK. |
This PR drops the
hashsumbinary, that was the way for uutils to implement standalone checksum algorithms, to introduce specific binaries.I chose to regroup all the common CLI handling into a
clisubmodule under theuucore::checksumfeature, that's debatable, as it introduces aclapdependency inuucore, which.Another way I can see it would be to replicate the way
base32,base64andbasencwork, where all the common implementation lives underbase32, and the other utils depend from it, but I'm not really convinced with this.Let's discuss it !