Skip to content

Fix crash from libVLC event detach #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vanities merged 1 commit into from
Jun 12, 2025
Merged

Fix crash from libVLC event detach #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions swiftchan/Views/Media/VLC/VLCMediaListPlayerUIView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,12 @@ class VLCMediaListPlayerUIView: UIView, VLCMediaPlayerDelegate {
/// Safely stop playback and release current media.
private func resetPlayer() {
let cleanup = {
self.mediaListPlayer.stop()
self.mediaListPlayer.mediaPlayer.stop()
// Detach the delegate and drawable first to avoid callbacks on
// a deallocated object. Then stop playback and clear the media.
self.mediaListPlayer.mediaPlayer.delegate = nil
self.mediaListPlayer.mediaPlayer.drawable = nil
self.mediaListPlayer.mediaPlayer.stop()
self.mediaListPlayer.stop()
self.mediaListPlayer.mediaPlayer.media = nil
self.mediaListPlayer.rootMedia = nil
self.currentMediaURL = nil
Expand Down
Loading