-
Notifications
You must be signed in to change notification settings - Fork 4
Add onnxruntime #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onnxruntime #19
Conversation
82dc03f to
6804927
Compare
This reverts commit 56f3512. Removing CreateFile2 calls was insufficient to enable win7 support. There are win8+ API calls which are not straightforward to replace: onnxruntime\core\platform\windows\env_time.cc(31): error C2065: 'GetSystemTimePreciseAsFileTime': undeclared identifier
|
Added conan patch which allows to keep macos-intel 10.13 and ios 12.0 min OS versions. |
|
I think there is issue with FILE_READ_ATTRIBUTES vs GENERIC_READ in W7 patch? Also keeping 192 which means v142 toolset is needed to keep proper support for builded components for Windows 7. |
A hasty copy-paste on my side it seems, but that's irrelevant as I reverted the commit due to other compile errors.
Thanks for pointing that out, I was under the impression "if it compiles, it runs" :) The compiler version is back to 192 for windows 7 now. |
|
Seems your patches were almost close. This should be Windows 7 compatible patch https://github.com/GeorgeK1ng/vcmi-dependencies/actions/runs/19713613028 - compiled just fine. So you need to grab there Windows 7 patch and recipe ones to allow v142 toolset. |
0e42897 to
76afc17
Compare
|
@GeorgeK1ng Thank you! I have added your suggested patch, finally the win7/win8 split is removed - the last remaining conan change in the PR has been dealt with. |
kambala-decapitator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also update PR description to match the current state
|
@kambala-decapitator any further comments? |
|
will check over the weekend |
smanolloff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. I will apply the suggested changes.
|
@kambala-decapitator I have made the requested changes. Please let me know if you have other suggestions. |
|
@kambala-decapitator I have replaced |
|
wow, windows and android dependencies have seriously increased in size |
ML libraries are huge in general (seems that size has not much priority). I think libonnx is still relative small compared e.g. to others. |
- adds workaround for conan-io/conan#19366 - partially reverts #19
|
yes, the size isn't a big deal, just an observation |
- adds workaround for conan-io/conan#19366 - partially reverts #19
- adds workaround for conan-io/conan#19366 - partially reverts #19
This PR contains changes needed to migrate MMAI from
libtorchtoonnxruntimeas @Laserlicht suggested hereIt adds
onnxruntime/1.18.1requirement with several patches address android-arm64 and windows-x86 compilation errors, as well as conan recipe errors from transitive dependencies.Please take a look and let me know if you have any comments.
The changes were tested with VCMI (develop branch) on MacOS 15 (arm), Windows 10 (x64), iOS 18 and Android 13 without noticing any issue.