SSAST-10519 Add option to collect debug data #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brett-Best
reviewed
May 6, 2025
NinjaLikesCheez
requested changes
May 8, 2025
Collaborator
NinjaLikesCheez
left a comment
NinjaLikesCheez
left a comment
There was a problem hiding this comment.
Requesting some changes - please let me know if you have any questions about my comments!
Sources/LogHandlers/Sources/LogHandlers/GenIRLoggingDefinition.swift
Outdated
Show resolved
Hide resolved
NinjaLikesCheez
previously requested changes
Jun 2, 2025
Collaborator
NinjaLikesCheez
left a comment
NinjaLikesCheez
left a comment
There was a problem hiding this comment.
One minor change to remove throws keyword since the init no longer throws.
NinjaLikesCheez
approved these changes
Jun 2, 2025
davdres
added a commit
that referenced
this pull request
Sep 19, 2025
* Handle targets with same name but in different projects * Issue #81 log unrequired targets instead of failing. * Issue #81 log PIF location & missing commands. * Issue #81 PIF workspace sort * Issue #81 Update version; add some logging Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com> * Update PIF/Sources/PIFSupport/PIFSupport.swift Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com> * Issue #81 Address linter & review issues. * Issue #81 Test unwrap of optional pif cache location. * ENG-55520: On sourceTree decode error, log & continue (#88) ENG-55520 * On sourceTree decode error, log & continue * SourceTree: refactor to class * SENG-9588 remove development release (#90) * SENG-9588 remove development release * SSAST-10500 Warn if multiple builds in xcode log (#91) * SSAST-10519 Add option to capture debug data (#92) A --capture option has been added to collect diagnostic data into a debug-data sub-folder of the IR directory. What data has been captured is written to the Gen-IR log. * SSAST-10900 Update help for debug data capture. (#93) * SSAST-11687 fix type fixing merge conflicts * SSAST-11687 fix swiftlint error-no error locally * Update build.yml Update to match my local version. The tests run locally. --------- Co-authored-by: bmxav <5422569+bmxav@users.noreply.github.com> Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.