Add start delay and complete control #23
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two features:
startDelayprop toProgressBarProviderstartandcompletefunctionsMotivation
My primary motivation behind this is to prevent progress bars from appearing for fast route changes. Showing a progress indicator for every route change isn't necessary if the navigation completes in under 300ms (imho)
To achieve this behavior, I needed:
In the existing implementation, it only provides a
start()function with no way to cancel or complete the progress explicitly.API Changes
Before
After
New Props
Usage