[Sequential Onloading] Support onloading and offloading frozen dataclasses

[kylesayrs]

Purpose

• Support onloading/offloading frozen dataclasses, which is sometimes required by experimental models

Changes

• Instead of modifying dataclasses in place, create a new dataclass instance when onloading/offloading

Tests

• Change test dataclass to be frozen

[gemini-code-assist]

Summary of Changes

Hello @kylesayrs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the IntermediatesCache to properly manage frozen dataclasses during onloading and offloading operations. The core change involves refactoring the internal value handling for dataclasses, moving from in-place modification to the creation of new instances. This ensures compatibility with immutable dataclasses, which are often required by experimental models, and prevents errors that would arise from attempting to modify frozen objects.

Highlights

• Frozen Dataclass Support: The onloading and offloading mechanisms now correctly handle frozen dataclasses, which are immutable by design.
• Immutable Object Handling: Instead of attempting to modify dataclass instances in place, the logic has been updated to create new dataclass instances with the updated values during onloading and offloading.
• Test Enhancements: The test suite has been updated to include a frozen=True dataclass, along with more complex nested structures, to validate the new functionality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds support for onloading and offloading frozen dataclasses by creating new instances instead of mutating them in-place. This change not only enables handling frozen dataclasses but also fixes significant underlying issues with state mutation, making the caching mechanism more robust and correct. The accompanying test updates are thorough and cover the new recursive and frozen dataclass logic well. My review includes one suggestion to add a comment to clarify a subtle implementation detail, which will improve future maintainability.