This repository was archived by the owner on May 2, 2024. It is now read-only.
Delphi Berlin #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indy switched to using TIdBytes to store and pass data, causing incompatibilities in newer Delphi versions.
Some notes:
This version compiles with XE7 and 10.1/Berlin. This probably breaks compatibility with older Delphi (well, Indy) versions. I don't know when this changed.
Delphi doesn't like conditional defines in the form class, and the incompatible event handler parameter list requires something like that. So either code needs to be rewritten in another way, or duplicated. I don't see an easy/clean/elegant solution. But in general I'd say that it's better to support newer Delphi's rather than older....