[bug] at is ignored #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmartelli
force-pushed
the
at-is-ignored
branch
2 times, most recently
from
54ce060 to
6e71640
Compare
lmartelli
force-pushed
the
at-is-ignored
branch
from
6e71640 to
c8ffb4b
Compare
Member
|
I'll look at this one. Thanks for raising it @lmartelli |
| .where().objectContains() | ||
| .at("/foo").isText() | ||
| .isEqualTo("{}")) | ||
| .isInstanceOf(AssertionFailedError.class); |
Member
There was a problem hiding this comment.
I can explain this one. It's sort of user-error, but it's sort of not.
When we use objectContains we're essentially relaxing the rules. We're telling the asserter to ignore any field not present in the expected.
The following version of your test does what your assertion is trying to do:
assertThatThrownBy(() ->
assertJson("{foo: 42}")
.where().objectContains()
.at("/foo").isText()
.isEqualTo("{foo:42}"))
.isInstanceOf(AssertionFailedError.class);
Member
|
@lmartelli - what's the status with this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a test case to show the bug.