Adjust wireframe example for compatibility mode #494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
reviewed
Mar 13, 2025
| const adapter = await navigator.gpu?.requestAdapter({ | ||
| featureLevel: 'compatibility', | ||
| }); | ||
| if (adapter.limits.maxStorageBuffersInVertexStage < 2) { |
Collaborator
There was a problem hiding this comment.
This will be undefined (if not in chrome with compat enabled). Technically this would work because undefined < 2 == NaN < 2 == false but we should be somehow explicit about it.
I made the limit members optional in gpuweb/types#168 which I think would catch this issue (but not the other one).
| } | ||
| const device = await adapter?.requestDevice({ | ||
| requiredLimits: { | ||
| maxStorageBuffersInVertexStage: 2, |
Collaborator
There was a problem hiding this comment.
I believe this will produce an error in standard browsers. It should only be set if the limit exists in adapter.limits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.