Skip to content

So, I think this is a minimal solution to this GtkWebkit WebView navigation problem #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbertShown merged 2 commits into from
Oct 22, 2025
Merged

So, I think this is a minimal solution to this GtkWebkit WebView navigation problem #660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b148d23
So, I think this is the minimal solution to this GtkWebkit WebView
hdijkema Oct 22, 2025
cee79ad
Remove unnecessary GTK_WEBVIEW_SET_IN_SHOW(win, true).
hdijkema Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 15 additions & 33 deletions src/webui.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,6 @@ typedef struct webui_event_inf_t {
void* gtk_win;
void* gtk_wv;
bool open;
bool in_show;
// WebUI Window
char* url;
bool navigate;
Expand All @@ -277,6 +276,8 @@ typedef struct webui_event_inf_t {
bool stop;
} _webui_wv_linux_t;

#define GTK_WEBVIEW_SET_IN_SHOW(win, status) if (win && win->has_all_events) { win->in_show = status; }

#else
extern bool _webui_macos_wv_new(int index, bool frameless, bool resizable);
extern void _webui_macos_wv_new_thread_safe(int index, bool frameless, bool resizable);
Expand Down Expand Up @@ -387,6 +388,7 @@ typedef struct _webui_window_t {
#ifdef _WIN32
_webui_wv_win32_t* webView;
#elif __linux__
bool in_show;
_webui_wv_linux_t* webView;
#else
_webui_wv_macos_t* webView;
Expand Down Expand Up @@ -8190,6 +8192,10 @@ static bool _webui_show_window(_webui_window_t* win, struct mg_connection* clien
_webui_log_debug("[Core]\t\t_webui_show_window(FILE, [%zu])\n", browser);
#endif

#if __linux__
GTK_WEBVIEW_SET_IN_SHOW(win, true)
#endif

#ifdef WEBUI_TLS
// TLS
if (_webui_is_empty(_webui.ssl_cert) || _webui_is_empty(_webui.ssl_key)) {
Expand Down Expand Up @@ -11876,35 +11882,19 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpReserved) {
}
}

static inline void _webui_wv_gtk_set_show(_webui_window_t* win, bool status) {
if (win) {
if (win->webView && win->has_all_events) {
win->webView->in_show = status;
}
}
}

static inline bool _webui_wv_gtk_is_show(_webui_window_t* win) {
if (win) {
if (win->webView && win->has_all_events) {
return win->webView->in_show;
}
}
return true;
}

static bool _webui_wv_event_decision(void *widget, void *decision, int decision_type, void *user_data) {
switch(decision_type) {
case WEBKIT_POLICY_DECISION_TYPE_NAVIGATION_ACTION: {

_webui_window_t* win = _webui_dereference_win_ptr(user_data);

if (!win->has_all_events) {
return false;
}

if (_webui_wv_gtk_is_show(win)) {
_webui_wv_gtk_set_show(win, false);
// If all events are handled, check in_show
if (win->has_all_events) {
if (win->in_show) { // Don't catch navigation event
GTK_WEBVIEW_SET_IN_SHOW(win, false)
return false;
}
} else { // Don't catch navigation event
return false;
}

Expand Down Expand Up @@ -12137,7 +12127,7 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpReserved) {
}

// Show
_webui_wv_gtk_set_show(win, true); // TODO: Check if we need this here because we are about to load a URI

webkit_web_view_load_uri(win->webView->gtk_wv, win->webView->url);
gtk_widget_show_all(win->webView->gtk_win);
win->webView->open = true;
Expand Down Expand Up @@ -12429,14 +12419,6 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpReserved) {
}
}

if (_webui.is_webview) {
// We have a Linux WebKitGTK WebView running
_webui_wv_gtk_set_show(win, true);
} else {
// Failed to start the Linux WebKitGTK
_webui_wv_gtk_set_show(win, false);
}

#ifdef WEBUI_LOG
_webui_log_debug("[Core]\t\t_webui_wv_show() -> Return [%d]\n", (_webui.is_webview == true));
#endif
Expand Down
Loading