feat: Enable use of CDN #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleytodd
approved these changes
Jan 16, 2025
Owner
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
This is a good addition, but we should include docs about this and clearly call out that use of 3rd party CDN's is dangerous and should be avoided. I can write this up if you like.
P.S. Sorry for the epic delay on all these, I had a lot of work to get express v5 out the door that took precedence over this package, but I am nearly caught up and will be doing a bunch of things to get this into shape for a new release, including this change.
Collaborator
Author
|
Hey @wesleytodd I can write the warning about 3rd party CDNs. Do you want me to add it to the README or somewhere else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to specify a CDN for the JavaScript files required to run the SwaggerUI