fix: forgit add shows dir view for submodules #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandr01d
force-pushed
the
fix-submodule-add-preview
branch
4 times, most recently
from
5d79510 to
a89ecef
Compare
sandr01d
changed the title
sandr01d
changed the title
cjappl
approved these changes
Dec 18, 2025
carlfriedrich
approved these changes
Dec 20, 2025
Collaborator
carlfriedrich
left a comment
carlfriedrich
left a comment
There was a problem hiding this comment.
Good catch. Thanks for the fix and thumbs up for the well implemented integration test!
Collaborator
Author
|
I'll keep this one open until #485 is merged, so I can implement the same solution in the new integration tests here. |
sandr01d
force-pushed
the
fix-submodule-add-preview
branch
from
a89ecef to
7dc1b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
Description
We currently show the directory preview in
forgit addwhen selecting any directory, including submodules. For submodules the directory preview is not very helpful. This PR ensures that we show the regular preview (git diff) instead, which shows the modified hash of the submodule and whether or not the submodule is dirty (contains uncomitted changes).Type of change
Test environment