feat: add ScrollDragDismissable widget for drag-to-dismiss functionality #216
Conversation
|
Dude this is amazing, I've had this on my to do list! I hope I find time to test this out this week 🤩 |
timcreatedit
left a comment
timcreatedit
left a comment
There was a problem hiding this comment.
Thanks for this! I only have two small comments, but otherwise LGTM! If possible, I'd love one or two tests on this, but no pressure, we can add them later
| /// Set this to false when your scrollable cannot move backwards (e.g. a | ||
| /// sheet is fully expanded) to allow this child's scrollable to transition | ||
| /// back to scrolling instead of dragging. | ||
| final bool scrollableCanMoveBack; |
There was a problem hiding this comment.
This parameter should probably not be exposed. Instead we should set it based on the current dismiss progress. If dismiss progress is 0, the scrollable can't move further back, but if it is > 0 it can
| flutter: | ||
| sdk: flutter | ||
| motor: ^1.0.1 | ||
| scroll_drag_detector: ^0.0.4 |
There was a problem hiding this comment.
could you update this to the latest dependency?
There was a problem hiding this comment.
that's also the reason the CI seems to be failing :)
|
hey @ShashankSMayya! Would you mind if I finish this up? Or do you have some time? I actually really love the idea and would kind of need it in one of my own projects |
|
Hey, I don't mind if you do it too. If not, I'll check it over this weekend if that works. I've been a bit busy last few weeks, sorry for the delay. |
2 participants
Description
This pull request introduces a new widget,
ScrollDragDismissable, which enables drag-to-dismiss functionality for scrollable content, similar to bottom sheet behavior. The implementation integrates this widget into the example app to enhance user interaction, and updates the package exports and dependencies accordingly.New drag-to-dismiss functionality for scrollable content:
ScrollDragDismissablewidget inscroll_drag_dismissable.dart, which allows scrollable widgets to be dismissed by dragging, handling gesture transitions between scrolling and dismissal, and integrating withHeroineVelocityfor smooth transitions.ScrollDragDismissablefrom the package inheroine.dartfor public use.scroll_drag_detectordependency to support gesture detection for the new widget.Integration into example app:
SecondDetailsPagein the example to use a scrollableListViewinstead of a staticCenterwidget, providing a better demonstration of scrollable drag-to-dismiss.DragDismissablewithScrollDragDismissablein the example's custom route, disablingscrollableCanMoveBackto match the intended UX.Checklist