Skip to content

Conversation

@shawnferry
Copy link

Do not merge this pull, it is here to make discussion easier

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this should be achieved via overlay_map.dtb with the common bits being targeted at any platform and the chip specific UART separately.

I tested breaking out the fragments it seemed to work as well as the whole file but the compatible directive doesn't seem to exclude application.

My current workaround is using dtoverlay wlmio-pi5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to remove overlays entirely for this package. overlay_map.dtb is a hack. Instead we are going to ship a wlmio.txt to be included with include wlmio.txt in config.txt that will handle all of the platform differences in an easy way for users.

There is a symlink to /boot/firmware/overlays at /boot/overlays so I think we will rely on this for now to support bullseye.

Comment on lines +8 to +13
executable('wl_factoryreset', 'factoryreset.c', dependencies: [wlmio_dep], install: true)
executable('wl_fwupdate', 'fwupdate.c', dependencies: [canard_dep, libgpiod_dep], install: true)
executable('wl_infodump', 'infodump.c', dependencies: [wlmio_dep], install: true)
executable('wl_monitor', 'monitor.c', dependencies: [wlmio_dep], install: true)
executable('wl_regtool', 'regtool.c', dependencies: [wlmio_dep], install: true)
executable('wl_store', 'store.c', dependencies: [wlmio_dep], install: true)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These names specifically are problematic in their generic nature the better alternative might be changing the prefix to /usr/libexec/widgetlords/ or /opt/widgetlords/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you seen any conflicts in the wild?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants