Skip to content

Conversation

@MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Dec 19, 2025

What's new in this PR

same as github.com//pull/1650 but for v9.x.x with a small difference that in js it is not changed not even a type alias since in the structs it is another field so no need to change it

fully support apple targets in kalium we need to have a unified interface between the android/kmp bindings
this PR adds a custom type converted to the jvm/android bindings to use kotlin time class instead of the java one
it should add no changes to wasm/ios bindings only for kotlin


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara requested a review from a team December 19, 2025 10:29
@MohamadJaara MohamadJaara force-pushed the mo/feat/use-kotlin-instant-for-cc-v9 branch from f6cb199 to ed6bce5 Compare December 19, 2025 10:32
@MohamadJaara MohamadJaara force-pushed the mo/feat/use-kotlin-instant-for-cc-v9 branch 2 times, most recently from 789ec6e to 35f84fb Compare December 19, 2025 11:30
@MohamadJaara MohamadJaara force-pushed the mo/feat/use-kotlin-instant-for-cc-v9 branch from 35f84fb to f841e1e Compare December 19, 2025 14:44
@istankovic
Copy link
Member

@MohamadJaara could you please fold the second commit into the first one? The first commit introduces the changes that the second one reverts so it does not make sense to add them in the first commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants