WPB-21964: Add Wire Meetings endpoints #4872

blackheaven · 2025-11-24T14:00:34Z

https://wearezeta.atlassian.net/browse/WPB-21964

Checklist

Add a new entry in an appropriate subdirectory of changelog.d
Read and follow the PR guidelines

libs/wire-subsystems/postgres-migrations/20251122120000-meetings.sql

libs/wire-subsystems/src/Wire/MeetingsSubsystem/Interpreter.hs

blackheaven · 2025-11-25T07:27:47Z

libs/wire-subsystems/src/Wire/MeetingsSubsystem/Interpreter.hs

+        then pure False
+        else do
+          -- Add invited email
+          Store.addInvitedEmail meetingId email


@akshaymankar Can I send e-mails in an upcoming PR?

@akshaymankar do we have the template?

services/galley/src/Galley/API/Meetings.hs

akshaymankar

There are more questions about this in the RFC. Let's wait before implementation.

libs/wire-api/src/Wire/API/Meeting.hs

blackheaven · 2025-12-10T11:45:55Z

@battermann I have reworked the flags

Copilot

Pull request overview

This PR implements a comprehensive meetings feature for Wire Server, allowing users to create, manage, and schedule meetings with email invitations. The implementation includes REST API endpoints, PostgreSQL-based persistence, background cleanup workers, and two feature flags to control access and premium features.

Key Changes

API Endpoints: Seven new REST endpoints for meeting CRUD operations and invitation management
Database Schema: New PostgreSQL meetings table with indexes for efficient querying
Feature Flags: Two new flags (meeting and meetingPremium) to control feature access and distinguish trial from premium meetings
Background Worker: Automated cleanup of old meetings with configurable retention policies

Reviewed changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated 31 comments.

Show a summary per file

File	Description
`libs/wire-api/src/Wire/API/Meeting.hs`	Core meeting data types (Meeting, NewMeeting, UpdateMeeting, Recurrence) with JSON schema definitions
`libs/wire-api/src/Wire/API/Routes/Public/Galley/Meetings.hs`	Public API route definitions for the seven meeting endpoints
`libs/wire-api/src/Wire/API/Error/Galley.hs`	New MeetingNotFound error type for 404 responses
`libs/wire-api/src/Wire/API/Conversation.hs`	Added MeetingConversation to GroupConvType enum
`libs/wire-api/src/Wire/API/Team/Feature.hs`	Defined MeetingConfig and MeetingPremiumConfig feature flags
`libs/wire-subsystems/src/Wire/MeetingsStore.hs`	Data access layer interface for meeting persistence operations
`libs/wire-subsystems/src/Wire/MeetingsStore/Postgres.hs`	PostgreSQL implementation of meetings store with parameterized queries
`libs/wire-subsystems/src/Wire/MeetingsSubsystem.hs`	Business logic interface for meeting operations
`libs/wire-subsystems/src/Wire/MeetingsSubsystem/Interpreter.hs`	Implementation of meeting business logic including authorization
`services/galley/src/Galley/API/Meetings.hs`	API handlers with feature flag checks and date validation
`services/galley/src/Galley/API/Public/Meetings.hs`	Public API integration mapping routes to handlers
`services/galley/src/Galley/Effects.hs`	Added MeetingsSubsystem and MeetingsStore to effect stack
`services/galley/src/Galley/App.hs`	Wired up meeting interpreters in the application
`services/galley/src/Galley/API/Create.hs`	Blocked MeetingConversation creation through normal conversation API
`services/galley/src/Galley/API/Util.hs`	Refactored notification helpers for conversation events
`services/galley/postgresql-migrations/001_meetings.sql`	Database migration creating meetings table with constraints and indexes
`postgres-schema.sql`	Added meetings table to main schema file
`services/galley/test/integration/API/Meetings.hs`	Comprehensive integration tests for all meeting endpoints
`services/background-worker/src/Wire/MeetingsCleanupWorker.hs`	Background worker for cleaning up expired meetings
`services/background-worker/src/Wire/BackgroundWorker/Options.hs`	Configuration options for meetings cleanup
`services/background-worker/src/Wire/BackgroundWorker.hs`	Integration of cleanup worker into background worker service
`charts/background-worker/values.yaml`	Helm chart configuration for cleanup worker settings
`integration/test/Test/FeatureFlags/PayingTeam.hs`	Feature flag tests (naming inconsistency with meetingPremium)
`changelog.d/2-features/WPB-21964`	Changelog entry describing the new features

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

postgres-schema.sql

services/galley/src/Galley/API/Meetings.hs

services/background-worker/src/Wire/MeetingsCleanupWorker.hs

libs/wire-subsystems/src/Wire/MeetingsStore/Postgres.hs

services/galley/src/Galley/API/Create.hs

libs/wire-subsystems/src/Wire/MeetingsStore/Postgres.hs

services/galley/src/Galley/API/Util.hs

integration/test/Test/FeatureFlags/PayingTeam.hs

battermann

For the feature flags we are missing:

stern endpoints and tests
helm charts, configmap, default values, docs etc.

For the other config (background-worker) we are missing the helm charts etc. too

(see PR guidelines)

integration/test/Test/FeatureFlags/PayingTeam.hs

integration/integration.cabal

libs/wire-api/src/Wire/API/Routes/Internal/Galley.hs

libs/wire-api/src/Wire/API/Meeting.hs

services/background-worker/src/Wire/MeetingsCleanupWorker.hs

libs/wire-subsystems/postgres-migrations/20251213223355-create-meetings-table.sql

battermann · 2025-12-12T16:24:38Z

libs/wire-subsystems/postgres-migrations/20251213223355-create-meetings-table.sql

+    -- Scheduling information
+    start_date timestamptz NOT NULL,
+    end_date timestamptz NOT NULL,
+    recurrence jsonb,


Not sure if we should store the recurrence untyped, like this. This is really an open question, not a critique.

services/galley/src/Galley/API/Meetings.hs

services/galley/test/integration/API/Meetings.hs

blackheaven · 2025-12-16T18:31:17Z

@battermann I think I have tackled everything, can you have a fresh look please?

Adds routes for MeetingConfig and MeetingPremiumConfig to the Stern API, including get, put, and lock/unlock routes. Updates the galley helm chart values to include default configurations for Meeting and MeetingPremium feature flags, and ensures these are properly exposed through the ConfigMap. Addresses part of the review comment regarding missing Stern endpoints, helm charts, and background worker config.

…ature flags The `payingTeam` feature flag is replaced by two new feature flags: - `meeting`: Controls access to the meetings API. When disabled, all meetings endpoints return 403 Forbidden. The feature is enabled and unlocked by default. - `meetingPremium`: Indicates whether a team has premium meeting features. When enabled, meetings created by team members are not marked as trial. This change also includes: - Renaming the `PayingTeam` feature flag test to `Meeting`. - Adding a new `MeetingPremium` feature flag test. - Updating helm charts and integration configurations.

Adds documentation for the `meeting` and `meetingPremium` feature flags to `docs/src/developer/reference/config-options.md`.

…ctions

…ence

The previous implementation of the meetings integration tests used incorrect JSON paths to access fields in the response bodies. This resulted in test failures. This commit corrects the following issues: - Uses 'qualified_id' to access the 'id' and 'domain' of a meeting. - Uses 'qualified_creator' to access the creator's ID. - Corrects the JSON field name for invited emails from 'invitedEmails' to 'invited_emails'. - Fixes the recurrence frequency field name from 'freq' to 'frequency'. - Corrects the extraction of 'teamId' from the 'createTeam' function's return value.

This commit updates the 'Frequency' enum to serialize to and from lowercase strings (e.g., "daily", "weekly"). - The instance now uses to convert the constructor names to lowercase. - The instance is updated to handle both uppercase and lowercase values for backward compatibility. - The instance is updated to reflect the new lowercase values. - The integration tests are updated to use and expect lowercase frequency values.

…Store/Postgres.hs

…cipants

…e api logic inn the subsystem

zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 24, 2025

blackheaven force-pushed the gdifolco/WPB-21964-wire-meetings-skeleton branch from ba6264c to 425ab2d Compare November 24, 2025 15:10

blackheaven marked this pull request as ready for review November 25, 2025 07:21

blackheaven requested review from a team as code owners November 25, 2025 07:21

blackheaven commented Nov 25, 2025

View reviewed changes

akshaymankar requested changes Nov 25, 2025

View reviewed changes

libs/wire-api/src/Wire/API/Meeting.hs Show resolved Hide resolved

libs/wire-api/src/Wire/API/Meeting.hs Outdated Show resolved Hide resolved

blackheaven force-pushed the gdifolco/WPB-21964-wire-meetings-skeleton branch from 63d6831 to 0c273b7 Compare November 26, 2025 18:29

blackheaven requested a review from akshaymankar November 27, 2025 16:36

blackheaven force-pushed the gdifolco/WPB-21964-wire-meetings-skeleton branch 2 times, most recently from ff9a9f2 to 221a3b5 Compare December 8, 2025 20:39

blackheaven requested a review from battermann December 10, 2025 11:45

blackheaven force-pushed the gdifolco/WPB-21964-wire-meetings-skeleton branch from e360e1b to d063175 Compare December 10, 2025 12:34

battermann requested a review from Copilot December 12, 2025 15:25

Copilot started reviewing on behalf of battermann December 12, 2025 15:25 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

battermann requested changes Dec 12, 2025

View reviewed changes

blackheaven requested a review from battermann December 16, 2025 18:31

WPB-21964: Add Wire Meetings endpoints

2ef0044

blackheaven force-pushed the gdifolco/WPB-21964-wire-meetings-skeleton branch from 603d167 to 3a44fbd Compare December 19, 2025 08:00

blackheaven and others added 7 commits December 19, 2025 09:34

fix: rework feature flags (meeting, meeting_premium)

ae23e5b

fix: schema recurrence field

c1e17d6

docs(api): frequency doc

759299a

docs: Add documentation for meeting and meetingPremium feature flags

7e83d14

Adds documentation for the `meeting` and `meetingPremium` feature flags to `docs/src/developer/reference/config-options.md`.

refactor: move MeetingId to Data.Id

1ad5e1d

blackheaven added 21 commits December 19, 2025 09:34

feat: Add updated_at column to meetings table and update relevant fun…

9c00b5c

…ctions

fix: list test name

fb85f33

fix: conversation creatio permissions

d203bb5

feat: Add recurrence tests and update existing tests to handle recurr…

9f31a22

…ence

feat: Add date validation tests for meeting creation and updates

eb84493

refactor: Move meetings migration to wire-subsystems

936258c

refactor: apply suggestions in libs/wire-subsystems/src/Wire/Meetings…

5d81620

…Store/Postgres.hs

refactor: clean integration test

44faf70

fix(cleanup): ensure conversation is associated

6fd5b24

fix: listMeetingsImpl returns also meeting the user is a simple parti…

94c87bc

…cipants

refactor: split clean up and regular meeting subsystem, partially mov…

ad40a6c

…e api logic inn the subsystem

fix: patching meeting dates

7f72dec

refactor(tests): use common status assertions

841e9c5

refactor: drop multi-qualified

84e6c4a

fix: formatting

ff9aa66

fix: hlint

0f74bc9

feature(background-worker): use cron

b4c0642

fix: queries exclude expired meetings

eb048ef

fix: formatting

bb6636d

blackheaven force-pushed the gdifolco/WPB-21964-wire-meetings-skeleton branch from 3a44fbd to bb6636d Compare December 19, 2025 08:34

WPB-21964: Add Wire Meetings endpoints #4872

Are you sure you want to change the base?

WPB-21964: Add Wire Meetings endpoints #4872

Uh oh!

Conversation

blackheaven commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Uh oh!

Uh oh!

blackheaven Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

blackheaven Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akshaymankar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

blackheaven commented Dec 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

battermann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

battermann Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

blackheaven commented Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

blackheaven commented Nov 24, 2025 •

edited

Loading