gpio-subsytem: Initialize gpio_dir as constant #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgasheev
requested changes
Nov 18, 2024
Collaborator
pgasheev
left a comment
pgasheev
left a comment
There was a problem hiding this comment.
Описания нет, проверки не проходят
pgasheev
requested changes
Dec 16, 2024
| BIT(EC_EXT_GPIO_A3) | | ||
| BIT(EC_EXT_GPIO_A4) | ||
| ); | ||
| gpio_ctx.gpio_ctrl &= ~INPUTS_ONLY_GPIOS; |
Collaborator
There was a problem hiding this comment.
Здесь нужно перечислить именно А1-А4, а не INPUTS_ONLY_GPIOS
| { | ||
| // Зануляем всё кроме V_OUT - он не должен сбрасываться при перезагрузке | ||
| gpio_ctx.gpio_ctrl &= BIT(EC_EXT_GPIO_V_OUT); | ||
| gpio_ctx.gpio_ctrl &= OUTPUTS_ONLY_GPIOS; |
Collaborator
There was a problem hiding this comment.
Оставить как было, даже коммент есть почему так
|
|
||
| -- Ilia Skochilov <ilia.skochilov@wirenboard.com> Tue, 22 Nov 2024 10:02:10 +0300 | ||
|
|
||
| wb-ec-firmware (2.0.1) stable; urgency=medium |
Collaborator
There was a problem hiding this comment.
Тут пробел лишний в начале строки как будто
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Данное изменение исправляет ошибку, которая возникала при сборке.
arm-none-eabi-gcc (GNU Tools for Arm Embedded Processors 7-2018-q2-update) 7.3.1 20180622 (release) [ARM/embedded-7-branch revision 261907]
src/gpio-subsytem.c:68:17: error: initializer element is not constant
.gpio_dir = outputs_only_gpios,
^~~~~~~~~~~~~~~~~~
src/gpio-subsytem.c:68:17: note: (near initialization for 'gpio_ctx.gpio_dir')
make[1]: *** [build/WB74/build/gpio-subsytem.o] Error 1