Skip to content

Add integration with CKEditor track changes feature #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carla-at-wiris merged 1 commit into from
Dec 19, 2025
Merged

Add integration with CKEditor track changes feature #1125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/ckeditor5/src/integration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,10 @@ export default class CKEditor5Integration extends IntegrationModel {
// Remove selection
if (!viewSelection.isCollapsed) {
for (const range of viewSelection.getRanges()) {
writer.remove(this.editorObject.editing.mapper.toModelRange(range));
const modelRange = this.editorObject.editing.mapper.toModelRange(range);
const modelSelection = this.editorObject.model.createSelection(modelRange);

this.editorObject.model.deleteContent(modelSelection);
}
}

Expand All @@ -189,7 +192,7 @@ export default class CKEditor5Integration extends IntegrationModel {
if (mathml) {
this.editorObject.model.insertObject(modelElementNew, position);
}
writer.remove(modelElementOld);
this.editorObject.model.deleteContent(this.editorObject.model.createSelection(modelElementOld,'on'));
}

// eslint-disable-next-line consistent-return
Expand Down Expand Up @@ -280,7 +283,9 @@ export default class CKEditor5Integration extends IntegrationModel {
}
}

writer.remove(range);
const modelSelection = this.editorObject.model.createSelection(range);

this.editorObject.model.deleteContent(modelSelection);
writer.insertText(`$$${returnObject.latex}$$`, startNode.getAttributes(), startPosition);
});
} else {
Expand Down
25 changes: 24 additions & 1 deletion packages/ckeditor5/src/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ export default class MathType extends Plugin {
currentInstance = integration;

// Add the MathType and ChemType commands to the editor
this._addCommands();
this._addCommands(integration);

// Add the track changes feature integration
this._addTrackChangesIntegration(integration);

// Add the buttons for MathType and ChemType
this._addViews(integration);
Expand Down Expand Up @@ -579,4 +582,24 @@ export default class MathType extends Plugin {
Latex,
};
}

_addTrackChangesIntegration(integration) {
const { editor } = this;

if (editor.plugins.has("TrackChangesEditing")) {
const trackChangesEditing = editor.plugins.get("TrackChangesEditing");

// Makes MathType and ChemType buttons available when editor is in the track changes mode
trackChangesEditing.enableCommand("MathType");
trackChangesEditing.enableCommand("ChemType");

// Adds custom label replacing the default 'mathml'.
// Handles both singular and plural forms.
trackChangesEditing.descriptionFactory.registerElementLabel(
"mathml",
quantity => (quantity > 1 ? quantity + ' ' : '') +
StringManager.get(quantity > 1 ? "formulas" : "formula", integration.getLanguage()),
);
}
}
}