Wof/3.1.0 #484
Merged
Wof/3.1.0 #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As all price feeds require explicit update conditions upon settlement.
Tommytrg
reviewed
Dec 10, 2025
| function testEncodeRadonReducer1Filter() external { | ||
| Witnet.RadonReducer memory reducer; | ||
| reducer.opcode = Witnet.RadonReduceOpcodes.Mode; | ||
| reducer.opcode = Witnet.RadonReducerMethods.Mode; |
Member
There was a problem hiding this comment.
Does RadonReducer still have opcode?
Suggested change
| reducer.opcode = Witnet.RadonReducerMethods.Mode; | |
| reducer.method = Witnet.RadonReducerMethods.Mode; |
| reducer.opcode = Witnet.RadonReducerMethods.Mode; | ||
| reducer.filters = new Witnet.RadonFilter[](1); | ||
| reducer.filters[0].opcode = Witnet.RadonFilterOpcodes.StandardDeviation; | ||
| reducer.filters[0].opcode = Witnet.RadonFilterMethods.StandardDeviation; |
Member
There was a problem hiding this comment.
Does RadonFilter still have opcode?
Suggested change
| reducer.filters[0].opcode = Witnet.RadonFilterMethods.StandardDeviation; | |
| reducer.filters[0].method = Witnet.RadonFilterMethods.StandardDeviation; |
Collaborator
Author
There was a problem hiding this comment.
nop, method instead
src/lib/wrappers/WitOracle.ts
Outdated
|
|
||
| /** | ||
| * Wrapper class for Wit/Oracle Radon Template artifacts as deployed in some supported EVM network. | ||
| * `IWitOracleRadonRequestTemplate` contracts enable smart contracts to formally verify Radon Requests |
Member
There was a problem hiding this comment.
Suggested change
| * `IWitOracleRadonRequestTemplate` contracts enable smart contracts to formally verify Radon Requests | |
| * `IWitOracleRadonRequestTemplateFactory` contracts enable smart contracts to formally verify Radon Requests |
src/lib/wrappers/WitPriceFeeds.ts
Outdated
| } | ||
|
|
||
| public async lookupPriceFeedID(id4: Witnet.HexString): Promise<Witnet.Hash> { | ||
| return this.contract.lookupPriceFeedID.staticCall(id4); |
Member
There was a problem hiding this comment.
Suggested change
| return this.contract.lookupPriceFeedID.staticCall(id4); | |
| return this.contract.lookupPriceFeedID32.staticCall(id4); |
src/lib/wrappers/WitPriceFeeds.ts
Outdated
| public async lookupPriceFeedQualityMetrics(id4: Witnet.HexString): Promise<PriceFeedQoS> { | ||
| return this.contract.lookupPriceFeedQualityMetrics.staticCall(id4).then((result: any) => ({ | ||
| computesEMA: result[0], | ||
| maxDeviationPercentage: Number(result[1]), |
Tommytrg
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.