Skip to content

Conversation

@Benestar
Copy link
Contributor

No description provided.

@Benestar Benestar added this to the 1.1 milestone Sep 20, 2014
RELEASE-NOTES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ByPropertyIdArray has all this moving stuff, which ByPropertyIdGrouper does not have. Unfortunately that stuff is needed. If it was not, we'd just be able to kill it and stick with a sane ByPropertyIdArray.

@Benestar
Copy link
Contributor Author

ByPropertyIdArray has all this moving stuff, which ByPropertyIdGrouper does not have. Unfortunately that stuff is needed. If it was not, we'd just be able to kill it and stick with a sane ByPropertyIdArray.

Removed the deprecation and started a rewrite of ByPropertyIdArray in #203

@Benestar Benestar changed the title Use ByPropertyIdGrouper in Claims and deprecate ByPropertyIdArray Use ByPropertyIdGrouper in Claims Sep 26, 2014
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is less readable than before

JeroenDeDauw added a commit that referenced this pull request Sep 27, 2014
@JeroenDeDauw JeroenDeDauw merged commit a9b69e6 into master Sep 27, 2014
@JeroenDeDauw JeroenDeDauw deleted the claimsbypropertyidgrouper branch September 27, 2014 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants