task: Log plugin load and editor initialization failures #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging these exceptions will improve the ability to act upon them and improve stability.
Ensure early logs are evaluated correctly.
The native host parsing expects the `stacktrace` value to be set, otherwise it discards the entire exception.
dcalhoun
added
the
[Type] Task
dcalhoun
commented
Dec 6, 2025
| setUpGlobalErrorHandlers(); | ||
| setBodyClasses(); | ||
| await awaitGBKitGlobal(); | ||
| setLogLevelFromGBKit(); |
Member
Author
There was a problem hiding this comment.
Hoisted from src/utils/editor.jsx to ensure messages from editor initialization log.
Comment on lines
+122
to
+125
| logException( err, { | ||
| isHandled: true, | ||
| handledBy: 'loadPluginsIfEnabled', | ||
| } ); |
Member
Author
There was a problem hiding this comment.
Improve observability of plugin loading failures.
Comment on lines
+154
to
+157
| logException( err, { | ||
| isHandled: true, | ||
| handledBy: 'setUpEditorEnvironment', | ||
| } ); |
Member
Author
There was a problem hiding this comment.
Improve observability of editor initialization failures.
| if ( stacktrace.length ) { | ||
| exception.stacktrace = stacktrace; | ||
| } | ||
| exception.stacktrace = parseStacktrace( originalException ); |
Member
Author
There was a problem hiding this comment.
Always set the stacktrace to avoid native hosts discarding logged exceptions—e.g., ios/Sources/GutenbergKit/Sources/EditorViewControllerDelegate.swift.
E.g., if fetchEditorAssets throws due to an error from the native host, the error object will have an empty stack trace in the JavaScript runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Log exceptions from failed plugin loading and editor initialization.
Why?
Ref CMM-887. Improve failure observability.
How?
stacktracevalue for exceptions sent across the bridge.Testing Instructions
ios/Demo-iOS/Sources/Views/EditorView.swift:163.Accessibility Testing Instructions
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.