Upgrade to Symfony 6.4 and employ new PHP 8.2 features #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MusikAnimal
force-pushed
the
symfony6
branch
5 times, most recently
from
5f07cfe to
7da9895
Compare
In addition to bringing us up-to-date with the latest LTS release, this fixes the annoying issue with local envs where the cache directory had to be manually cleared. Symfony 6 brings a refreshed debug toolbar among other benefits as well. Employed PHP features now that we can use 8.2: - We now use native PHP method attributes instead of annotations for routing. Other annotations can likely be moved to attributes at some point, too. - Use unioned types in method signatures where possible, and if the resulting doc block adds no information, remove it - Use constructor property promotion - Use str_starts_with() where possible - Use nullsafe operations in conjunction with null coalesce - Remove unused variables from signature of catch statements Bug: T400929
MusikAnimal
force-pushed
the
symfony6
branch
from
7da9895 to
6cacb0d
Compare
MusikAnimal
changed the title
Member
Author
|
@agoujot I'm not asking for a thorough review here (it's so big of a PR that GitHub won't even let you browse but one file at a time!), but if you could test this locally to make sure things generally look good, etc., that'd be helpful! I thought it would be good to get this out before my sabbatical (i.e. the annoying issue with caching on local envs). |
Member
Author
|
If we get this merged in time, I will also help resolve conflicts in your other PRs, if you'd like. They shouldn't be too terrible I imagine, but there will certainly be some conflicts. |
agoujot
approved these changes
Dec 28, 2025
Member
agoujot
left a comment
agoujot
left a comment
There was a problem hiding this comment.
LGTM? Played around some, everything seems to still be working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This includes #594. Also make sure you run
composer installbefore testing!In addition to bringing us up-to-date with the latest LTS release,
this fixes the annoying issue with local envs where the cache directory
had to be manually cleared. Symfony 6 brings a refreshed debug toolbar
among other benefits as well.
Employed PHP features now that we can use 8.2:
routing. Other annotations can likely be moved to attributes at some
point, too.
resulting doc block adds no information, remove it
Bug: T400929