GC, PC: use - in pagination to prevent slash collapsing #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Re CI failure: It looks like assets were generated with the wrong version of NPM/Node possibly, or you forgot to commit them? Anyway, once I finally found the time, I was able to fix the core issue in prod: https://phabricator.wikimedia.org/T403566#11485863 Sorry it took me so long to get back to giving it another try. |
Member
Author
|
This was more of an emergency fix for the two tools concerned, and it's not a proper switch to always using -s. Now that the urgent issue is gone, we've got some more time to find something better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully we should get a better way out, but meanwhile.... here we are.
(note: CI appears to be failing again: tests pass locally)
Bug: T403566