Description: Improved string fields in the table #1566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redmonkez12
added
the
type: enhancement
Innders
requested changes
Oct 6, 2025
Member
There was a problem hiding this comment.
- Update PR to something nice.
- Match the height and border of the rename dialog. Use (https://github.com/ynput/ayon-frontend/blob/fb56760b506484b24fd8a6583fc26a0ab8b1f547/shared/src/components/LinksManager/CellEditingDialog.tsx)
- 500ms feels pretty fast, try 900ms.
- This seems to only work for the description attribute. It should work for all text attributes.
- Only show the preview when the text is overflowing.
- Remove the focus outline when previewing.
| </StyledPopUp> | ||
| </StyledBackdrop> | ||
| ) : ( | ||
| <StyledPopUp |
Member
There was a problem hiding this comment.
We already have a component that can deal with overview table dialogs.
redmonkez12
changed the title
Innders
requested changes
Oct 8, 2025
Member
There was a problem hiding this comment.
- Block global shortcuts when editing with
block-shortcutsclassName. Currently if you type m+m it will jump to the marketplace. - ctrl/cmd + v does not work for pasting.
- ctrl/cmd + a does not work for selecting all. Does ctrl/cmd just not work?
- Try to show all the content preview and editing (height: fit-content) up to a sensible maximum height.
- Hovering does not work if your mouse is on the edge of the cell and not directly over the text, it would work for the whole cell.
- When selected and hovering it is great you can move the mouse over the preview without it closing. The problem is that it gets stuck open. Close the preview when the mouse moves outside of the cell or preview. I have marked the green area of where the preview should stay open, when going outside of the green area the preview should close.
- Bring the initial hover delay down to 600ms.
- Hovering warm state.
When hovering over a cell for the first time, there should be a short delay before the preview appears — that’s expected. However, once the first preview has been triggered, hovering over other cells should show their previews instantly, with no delay.
If the user stops hovering over any cell for around 500ms (or more), the system should reset and apply the initial delay again on the next hover.
In the screen recording below, you can see that the preview is delayed for every hover, which isn’t correct — only the first preview should have a delay.
Let me know if that’s unclear.
Screen.Recording.2025-10-08.at.08.04.16.mov
redmonkez12
force-pushed
the
1352-Table-improved-string-fields-like-description
branch
from
458460b to
8539b57
Compare
Innders
requested changes
Oct 9, 2025
Member
Innders
left a comment
Innders
left a comment
There was a problem hiding this comment.
It's starting to feel really useable and useful now!
- Prevent the re-formatting of text when going from preview to editor. The text jumps when clicking the preview to edit. This is probably because there is now a border shifting the content.
- The current min-width of the dialog is good but it should try to fill the width of the column when it can, especially if there is a lot of content.
- Paragraph spacing is not preserved (or not shown). I think this is an issue everywhere.
- When the column height is more then we should display the cell text on multiple lines to make better use of the space.
- Are markdown shortcuts meant to be working because
cmd+Bdoes nothing. (not a priority)
…scription # Conflicts: # shared/src/components/DetailsPanelDetails/DescriptionSection.styles.ts
redmonkez12
force-pushed
the
1352-Table-improved-string-fields-like-description
branch
from
8539b57 to
082cfd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds markdown support to the description field with improved preview and editing UX.
Key Features
Markdown Editing (Shortcuts)
There’s no dedicated markdown action tab; manage formatting via keyboard shortcuts:
How to Test
Notes
Screen.Recording.2025-10-06.at.16.01.34.mov
Screen.Recording.2025-10-06.at.16.02.00.mov