GraphQl: Limit and sorting options #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
GraphQl now does support to define limit of fetched entities and order in which are fetched.
Additional review information
The new functionality was added for events and activilities methods as they might have actuall use-case.
Testing notes:
get_events-> you should get many events sorted by ascending order based on creation date.get_eventswithorderset toSortOrder.descending-> the same amount of events from in opposite order.get_eventswithlimitset to 10 -> you should get first 10 events available in your server.get_eventswithlimitset to 10 andorderset toSortOrder.descending-> you should get last 10 events available in your server.