refactor!: Use a proper Color struct for the color properties
#663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataTriny
requested changes
Dec 22, 2025
| #[cfg_attr(feature = "schemars", derive(JsonSchema))] | ||
| #[cfg_attr(feature = "serde", serde(deny_unknown_fields))] | ||
| #[repr(C)] | ||
| pub struct Color { |
Member
There was a problem hiding this comment.
If the goal is to improve readability, I'd suggest renaming the fields with actual words, we're not all graphics programming experts. Here's the documentation of the Bevy Color struct for reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so there's no confusion about how the color components are packed into an integer. And since the original doc comments specified RGBA, I've kept the alpha component.