(1.21.1) Fix bug with mixed slabs and waterlogging #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed slab is broken
throckmorpheus
changed the title
CJMinecraft01
requested changes
Jan 3, 2026
Owner
CJMinecraft01
left a comment
CJMinecraft01
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Similar to #318 in feedback :)
Comment on lines
-142
to
+144
| final var slabState = slabContainer.getBlockState(); | ||
| var slabState = slabContainer.getBlockState(); | ||
| slabState = slabState.setValue(BlockStateProperties.WATERLOGGED, false); |
Owner
There was a problem hiding this comment.
Similar to #318, we should use trySetValue here since we cannot assume the state has a WATERLOGGED property. I think we also want this to be a final var here so can just do it in one line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you placed a different slab type onto a waterlogged slab to create a double slab, then broke the slab that hadn't been waterlogged, the remaining slab would return to a waterlogged state (but not flow out until updated).
This fixes it so the water is removed, like what happens with two slabs of the same type (and vertical slabs, which never had this issue).