Skip to content

LIMS-1986: Show main menu on click #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndg63276 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

LIMS-1986: Show main menu on click #1013

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
756a166
LIMS-1986: Show main menu on click
Dec 5, 2025
dd65779
Merge branch 'master' into improvement/LIMS-1986/show-main-menu-on-click
Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions client/src/js/app/components/navbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
<router-link
to=""
class="tw-relative navbar-item"
@mouseover.native="showProposalMenu=true"
@mouseover.native="handleMouseOver"
@mouseleave.native="showProposalMenu=false"
@click.native="showProposalMenu=false"
@click.native="handleClick"
>
<p class="tw-text-xs">
<i
Expand Down Expand Up @@ -152,9 +152,10 @@ export default {
showHelpMenu: false,
// If hover over proposal menu flag
showProposalMenu: false,
lastHoverOpenAt: 0,
hoverGraceTimeMs: 100,
}
},

computed: {
proposal: function() {
return this.$store.getters['proposal/currentProposal']
Expand Down Expand Up @@ -199,6 +200,23 @@ export default {
e.stopPropagation()
}
},

handleMouseOver() {
if (!this.showProposalMenu) {
this.lastHoverOpenAt = Date.now()
}
this.showProposalMenu = true
},

handleClick() {
// If the menu was opened by a very recent hover, ignore the click that would close it.
if ((Date.now() - this.lastHoverOpenAt) < this.hoverGraceTimeMs) {
return
}
// Otherwise toggle as normal
this.showProposalMenu = !this.showProposalMenu

},
}
}
</script>
Expand Down
Loading