Add Jungfrau to i24 #1473
Closed
Add Jungfrau to i24 #1473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
4 tasks
Contributor
|
@olliesilvester to tidy up, we'll merge w/o the |
jacob720
approved these changes
Nov 24, 2025
Contributor
jacob720
left a comment
jacob720
left a comment
There was a problem hiding this comment.
Looks good to me, as long as those comments don't need to be done in this PR
| set_log_beamline(BL) | ||
| set_utils_beamline(BL) | ||
|
|
||
| # TODO check jungfrau is connected here |
Contributor
There was a problem hiding this comment.
Does this still need to be done in this PR?
| If this is called when already instantiated, it will return the existing object.""" | ||
| file_provider = AutoIncrementFilenameProvider(filename) | ||
|
|
||
| # TODO find the prefixes + odin nodes |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of DiamondLightSource/mx-bluesky#1200
Requires bluesky/ophyd-async#999
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}