Skip to content

Conversation

@olliesilvester
Copy link
Collaborator

@olliesilvester olliesilvester commented Nov 19, 2025

Supersedes #1473

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram
Copy link
Contributor

May supersede #1473, @olliesilvester to get these into one PR and if it's a simple one let's just get them merged

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.12%. Comparing base (63cc644) to head (a3cd1eb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1721   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files         282      282           
  Lines       10687    10696    +9     
=======================================
+ Hits        10593    10602    +9     
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olliesilvester olliesilvester marked this pull request as ready for review December 19, 2025 14:14
@olliesilvester olliesilvester requested a review from a team as a code owner December 19, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants