Skip to content

Conversation

@menli820
Copy link
Contributor

@menli820 menli820 commented Dec 2, 2025

This option allows keeping systems in crashed state after bugcheck instead of automatically rebooting, enabling better debugging of system crashes during HCK installation and testing.

This option allows keeping systems in crashed state after bugcheck
instead of automatically rebooting, enabling better debugging of
system crashes during HCK installation and testing.

Signed-off-by: menli <menli@redhat.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @menli820, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new command-line option, --no-reboot-after-bugcheck, designed to improve the debugging experience for system crashes. By preventing automatic reboots after a bugcheck, this feature allows developers to keep systems in a crashed state, facilitating deeper investigation during HCK installation and testing scenarios.

Highlights

  • New Command-Line Option: A new command-line option, --no-reboot-after-bugcheck, has been introduced to control system behavior after a crash.
  • Enhanced Debugging: This option prevents automatic system reboots following a bugcheck, allowing for more thorough debugging of the crashed state during HCK installation and testing.
  • Configuration Integration: The value of the --no-reboot-after-bugcheck option is now propagated through the HCK installation configuration to the setup scripts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new command-line option --no-reboot-after-bugcheck for the install command. This is useful for debugging system crashes during HCK installation by preventing the machine from automatically rebooting after a bugcheck. The changes correctly add the option, pass it through to the installation engine, and configure the setup scripts. My feedback includes a minor style suggestion to improve code readability.

@menli820
Copy link
Contributor Author

menli820 commented Dec 3, 2025

@kostyanf14 please help review it when you free , thanks

@kostyanf14 kostyanf14 merged commit 6f7ba2d into HCK-CI:master Dec 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants