Skip to content

Add --no-reboot-after-bugcheck option for crash debugging #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kostyanf14 merged 1 commit into from
Dec 3, 2025
Merged

Add --no-reboot-after-bugcheck option for crash debugging #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def define_options(parser)

# class InstallOptions
class InstallOptions
attr_accessor :platform, :force, :skip_client, :drivers, :driver_path, :debug
attr_accessor :platform, :force, :skip_client, :drivers, :driver_path, :debug, :no_reboot_after_bugcheck

def create_parser
OptionParser.new do |parser|
Expand All @@ -221,6 +221,7 @@ def define_options(parser)
@skip_client = false
@drivers = []
@debug = false
@no_reboot_after_bugcheck = false

parser.on('--debug', TrueClass, 'Enable debug mode',
&method(:debug=))
Expand All @@ -244,6 +245,10 @@ def define_options(parser)
parser.on('--driver-path <driver_path>', String,
'Path to the location of the driver wanted to be installed',
&method(:driver_path=))

parser.on('--no-reboot-after-bugcheck', TrueClass,
'Keep system in crashed state after crash for debugging (disables automatic reboot)',
&method(:no_reboot_after_bugcheck=))
end
# rubocop:enable Metrics/MethodLength
end
Expand Down
3 changes: 2 additions & 1 deletion lib/engines/hckinstall/hckinstall.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,8 @@ def prepare_setup_scripts_config
config = {
kit_type:,
hlk_kit_ver: kit_version,
debug: @project.options.install.debug
debug: @project.options.install.debug,
no_reboot_after_bugcheck: @project.options.install.no_reboot_after_bugcheck
}

@kit_path = find_kit(kit_type, kit_version)
Expand Down
3 changes: 2 additions & 1 deletion lib/engines/hckinstall/setup_scripts_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ module Helper
kit_type: '',
hlk_kit_ver: '',
remove_gui: '',
debug: ''
debug: '',
no_reboot_after_bugcheck: ''
}.freeze

def validate_setup_scripts_config(config)
Expand Down
Loading