Skip to content

Conversation

@omarisgreat
Copy link
Contributor

No description provided.

omarisgreat and others added 27 commits February 10, 2025 14:56
Update package.json
Added hl7.fhir.eu.extensions.r4
Removing "hl7.fhir.eu.laboratory": "0.1.1",
hl7.fhir.eu.laboratory": "0.1.0-ballot
@KazeemHamzat
Copy link
Collaborator

1.The "hl7.fhir.eu.laboratory": "0.1.1", is required to validate some examples but the problem seem to be the version '0.1.1'
I have changed it to a balloted version "hl7.fhir.eu.laboratory": "0.1.0-ballot", the error is now resolved but some syntax errors are now required to be fixed in one of the Bundle Examples.. Validator issue is now resolved.
2 CodeSystem, http://www.sequenceontology.org, currently mapped to the element Observation.component:variation-code is also failing validation but I have replaced it with a code I found here, missense_variant [SO_0001583], presently flagged with warning by the validator. We may have to apply the rule for validator to ignore it like the code for genes: http://varnomen.hgvs.org if codesystem-http://www.sequenceontology.org is mandatory.

should allow validation of resources against any package in dependencies (not a fix but issues in Bundle are not useful)
Not adding anything material to the package as Composition validates fine
@omarisgreat
Copy link
Contributor Author

Hi @KazeemHamzat, I am done with the Bundle, it does not want to Validate no matter what changes are made, even though the other resources are validating against EU Lab just fine. I've decided to cut it as it is not contributing much to the IG.

Removed EU Extensions
@KazeemHamzat
Copy link
Collaborator

@ryma2fhir , there is need to make exception rule on the validator to ignore CodeSystem-http://www.sequenceontology.org
The same rule that was applied to http://varnomen.hgvs.org/

@omarisgreat
Copy link
Contributor Author

@KazeemHamzat, I've made the update to the validation repo to ignore the SequenceOntology CS issues. The PR should now be ready to review

Copy link
Collaborator

@KazeemHamzat KazeemHamzat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Minor issues to be corrected,
  2. Are the ServiceRequest and Task instance not expected to conform to EU-Lab profiles?

Updated Observation reference
Updated date on NamingSystem
Added EU Profiles to ServiceRequest
@omarisgreat
Copy link
Contributor Author

@KazeemHamzat, addressed comments, and added profile to ServiceRequest. There is no Task profile in EU Lab so I've left that as is.

Copy link
Collaborator

@KazeemHamzat KazeemHamzat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@omarisgreat omarisgreat merged commit 027f435 into main Sep 8, 2025
1 check passed
@omarisgreat omarisgreat deleted the Issue-2663 branch September 8, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants