Oauth: change to in app browser #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dewabisma
changed the title
dewabisma
changed the title
n13
reviewed
Dec 9, 2025
| case AppLifecycleState.detached: | ||
| break; | ||
|
|
||
| case AppLifecycleState.resumed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closed previous PR #335 because of wanting to make it more secure by using domain association. After trying many ways and fighting with other package. I come up with a nice fallback instead by using existing package that we use
url_launcher. The good news, it works for android even the deep linking wohooo!! The bad news it still fail for the ios but I have a nice website page fallback which I think good enough still. So, to make sure we get the data change I also listen to state change in the associations screen.Screenshots