Skip to content

Oauth: change to in app browser #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dewabisma merged 1 commit into from
Dec 9, 2025
Merged

Oauth: change to in app browser #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions mobile-app/lib/features/main/screens/account_associations_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class AccountAssociationsScreen extends ConsumerStatefulWidget {
ConsumerState<AccountAssociationsScreen> createState() => _AccountAssociationsScreenState();
}

class _AccountAssociationsScreenState extends ConsumerState<AccountAssociationsScreen> {
class _AccountAssociationsScreenState extends ConsumerState<AccountAssociationsScreen> with WidgetsBindingObserver {
final TaskmasterService _taskmasterService = TaskmasterService();

final _ethAddress = TextEditingController();
Expand Down Expand Up @@ -92,7 +92,7 @@ class _AccountAssociationsScreenState extends ConsumerState<AccountAssociationsS
final oauthRequest = await _taskmasterService.generateAssociateXLink();
final Uri url = Uri.parse(oauthRequest.url);

launchUrl(url, mode: LaunchMode.externalApplication);
launchUrl(url, mode: LaunchMode.inAppBrowserView);
} catch (e) {
print('Failed associating X account: $e');

Expand All @@ -111,6 +111,33 @@ class _AccountAssociationsScreenState extends ConsumerState<AccountAssociationsS
ref.invalidate(accountAssociationsProvider);
}

@override
void initState() {
super.initState();
WidgetsBinding.instance.addObserver(this);
}

@override
void dispose() {
WidgetsBinding.instance.removeObserver(this);
super.dispose();
}

@override
void didChangeAppLifecycleState(AppLifecycleState state) {
switch (state) {
case AppLifecycleState.paused:
case AppLifecycleState.inactive:
case AppLifecycleState.hidden:
case AppLifecycleState.detached:
break;

case AppLifecycleState.resumed:
Copy link
Collaborator

@n13 n13 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats nice haha

ref.invalidate(accountAssociationsProvider);
break;
}
}

@override
Widget build(BuildContext context) {
final associationsAsync = ref.watch(accountAssociationsProvider);
Expand Down