Skip to content

Conversation

@thassiov
Copy link
Contributor

@thassiov thassiov commented Oct 6, 2022

Proposed changes (including videos or screenshots)

Make the apps-engine work as a service.

Issue(s)

Steps to test or reproduce

Further comments

AECO-55
Depends on RocketChat/Rocket.Chat.Apps-engine#587

@lgtm-com
Copy link

lgtm-com bot commented Oct 11, 2022

This pull request introduces 6 alerts when merging d63f8ab into ff732f9 - view on LGTM.com

new alerts:

  • 6 for Property access on null or undefined

@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2022

This pull request introduces 18 alerts when merging 5077c25 into 1be4ad2 - view on LGTM.com

new alerts:

  • 10 for Syntax error
  • 5 for Superfluous trailing arguments
  • 3 for Property access on null or undefined

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@d-gubert d-gubert removed this from the 6.2.0 milestone May 11, 2023
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 12, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Rafael Tapia seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants