Skip to content

Conversation

@kartik-ornate
Copy link

Proposed changes

This PR fixes visual and functional issues in the RequestTrialForm component in onboarding-ui.

Specific changes:

  1. Fixed Translations: Wrapped the form labels (Email, Org Name, etc.) in the t() function. They were previously rendering raw translation keys (e.g., form.requestTrialForm...).
  2. Fixed Spacing: Added mis={16} (Margin Inline Start) to the checkbox labels. This fixes the issue where the text was squashed against the checkbox.
  3. Bug Fixes:
    • Corrected the "Organization Size" field error logic (it was incorrectly checking for email errors).
    • Added id attributes to the checkboxes so clicking the label text correctly toggles the input.

Screenshots

After Fix:
Screenshot 2025-12-11 034536
Screenshot 2025-12-11 034536

Issue(s)

Closes #1582

Further comments

Tested locally via Storybook. The form now displays correct English labels and follows standard spacing guidelines.

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2025

⚠️ No Changeset found

Latest commit: 118f230

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: workspace Trial Form – Labels Not Translated & UI Issues

2 participants