Skip to content

fix(onboarding-ui): RequestTrialForm translation keys and checkbox sp… #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kartik-ornate wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(onboarding-ui): RequestTrialForm translation keys and checkbox sp… #1804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bc8cff
fix(onboarding-ui): RequestTrialForm translation keys and checkbox sp…
kartik-ornate Dec 10, 2025
118f230
Merge branch 'main' into main
kartik-ornate Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/onboarding-ui/src/forms/RequestTrialForm/RequestTrialForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ const RequestTrialForm = ({
placeholder={t(
'form.requestTrialForm.fields.organizationSize.placeholder',
)}
error={errors?.email?.message || undefined}
error={errors?.organizationSize?.message || undefined}
/>
)}
defaultValue={defaultValues?.organizationSize}
Expand Down Expand Up @@ -156,8 +156,9 @@ const RequestTrialForm = ({
fontScale='c1'
lineHeight={20}
>
<CheckBox mie={8} {...register('updates')} />{' '}
<Box is='label' htmlFor='updates'>
<CheckBox id="updates" {...register('updates')} />{' '}
{/* FIX: mis={16} pushes the LABEL away from the checkbox */}
<Box is='label' htmlFor='updates' mis={16}>
{t('form.registeredServerForm.keepInformed')}
</Box>
</Box>
Expand All @@ -170,10 +171,11 @@ const RequestTrialForm = ({
lineHeight={20}
>
<CheckBox
mie={8}
id="agreement"
{...register('agreement', { required: true })}
/>{' '}
<Box is='label' htmlFor='agreement' withRichContent>

<Box is='label' htmlFor='agreement' withRichContent mis={16}>
<Trans i18nKey='component.form.termsAndConditions'>
I agree with
<a href={termsHref} target='_blank' rel='noopener noreferrer'>
Expand Down Expand Up @@ -216,4 +218,4 @@ const RequestTrialForm = ({
);
};

export default RequestTrialForm;
export default RequestTrialForm;