fix(fuselage): add a11y warning and enforce default type="button" for Buttons #1814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR addresses two areas of improvement for the
Buttoncomponent:Buttonis icon-only, loading, or square but lacks anaria-labeloraria-labelledby.type="button"as the default attribute. In HTML, buttons inside forms default totype="submit", which often leads to unintended form submissions when developers use buttons for actions like "Cancel" or "Close".Why this is needed
Changes
typewith a default of'button'.Children.toArraycheck for accessible text content.process.env.NODE_ENVcheck for console warnings.Testing
<Button icon="edit" />triggers a warning.<Button type="submit">Submit</Button>still renders correctly as a submit button.closes #1813