Skip to content

fix(fuselage): add a11y warning and enforce default type="button" for Buttons #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kalpana-chavhan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(fuselage): add a11y warning and enforce default type="button" for Buttons #1814

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd1753c
fix(a11y): add dev warning for buttons missing accessible names
Kalpana-chavhan Jan 1, 2026
d4cc450
fix(fuselage): add button a11y warning and default type='button'
Kalpana-chavhan Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 33 additions & 12 deletions packages/fuselage/src/components/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { AllHTMLAttributes } from 'react';
import { forwardRef, useMemo } from 'react';
import { forwardRef, useMemo, Children } from 'react';

import { Box, type BoxProps } from '../Box';
import { Icon, type IconProps } from '../Icon';
Expand Down Expand Up @@ -39,6 +39,7 @@ const Button = forwardRef<HTMLButtonElement | HTMLAnchorElement, ButtonProps>(
external,
icon,
is = 'button',
type = 'button', // Defaulting to 'button' here for safety
rel: _rel,
tiny,
mini,
Expand All @@ -53,15 +54,20 @@ const Button = forwardRef<HTMLButtonElement | HTMLAnchorElement, ButtonProps>(
},
ref,
) {
const extraProps =
(is === 'a' && {
rel: external ? 'noopener noreferrer' : undefined,
target: external ? '_blank' : undefined,
}) ||
(is === 'button' && {
type: 'button',
}) ||
{};
const extraProps = useMemo(() => {
if (is === 'a') {
return {
rel: external ? 'noopener noreferrer' : undefined,
target: external ? '_blank' : undefined,
};
}

if (is === 'button') {
return { type }; // Uses the 'type' prop (default 'button')
}

return {};
}, [is, external, type]);

const kindAndVariantProps = useMemo(() => {
const variant =
Expand All @@ -83,10 +89,25 @@ const Button = forwardRef<HTMLButtonElement | HTMLAnchorElement, ButtonProps>(
return {};
}, [primary, secondary, danger, warning, success]);

// --- Accessibility Check (Dev Only) ---
if (process.env.NODE_ENV !== 'production') {
const childrenArray = Children.toArray(children);
const hasTextContent = childrenArray.some(
(child) => typeof child === 'string' && child.trim().length > 0
);

const isVisualOnly = !hasTextContent && (!!icon || !!loading || square);

if (isVisualOnly && !props['aria-label'] && !props['aria-labelledby']) {
console.warn(
`Fuselage [Button]: Buttons without visible text (icon-only or square buttons) must provide an 'aria-label' or 'aria-labelledby' prop for accessibility.`
);
}
}

return (
<Box
is={is}
type='button'
rcx-button
{...kindAndVariantProps}
rcx-button--small={small}
Expand Down Expand Up @@ -114,4 +135,4 @@ const Button = forwardRef<HTMLButtonElement | HTMLAnchorElement, ButtonProps>(
},
);

export default Button;
export default Button;